Researchers at Truffle Security have found, or arguably rediscovered, that data from deleted GitHub repositories (public or private) and from deleted copies (forks) of repositories isn’t necessarily deleted.

Joe Leon, a security researcher with the outfit, said in an advisory on Wednesday that being able to access deleted repo data – such as APIs keys – represents a security risk. And he proposed a new term to describe the alleged vulnerability: Cross Fork Object Reference (CFOR).

“A CFOR vulnerability occurs when one repository fork can access sensitive data from another fork (including data from private and deleted forks),” Leon explained.

For example, the firm showed how one can fork a repository, commit data to it, delete the fork, and then access the supposedly deleted commit data via the original repository.

The researchers also created a repo, forked it, and showed how data not synced with the fork continues to be accessible through the fork after the original repo is deleted. You can watch that particular demo.

  • Mubelotix
    link
    fedilink
    English
    arrow-up
    34
    arrow-down
    2
    ·
    4 months ago

    This is not a GitHub issue. It’s a GIT feature. People are always going to clone your repo.

    • Morphit @feddit.uk
      link
      fedilink
      English
      arrow-up
      8
      ·
      4 months ago

      Well, sort of. GitHub certainly could refuse to render orphan commits. They pop up a banner saying so but I don’t see why they should show the commit at all. They could still keep the data until it’s garbage collected since a user might re-upload the commit in a new branch.

      This seems like a non-issue though since someone who hasn’t already seen the disclosed information would need to somehow determine the hash of the deleted commit.

      • Morphit @feddit.uk
        link
        fedilink
        English
        arrow-up
        8
        ·
        4 months ago

        Ah - Actually reading the article reveals why this is actually an issue:

        What’s more, Ayrey explained, you don’t even need the full identifying hash to access the commit. “If you know the first four characters of the identifier, GitHub will almost auto-complete the rest of the identifier for you,” he said, noting that with just sixty-five thousand possible combinations for those characters, that’s a small enough number to test all the possibilities.

        So enumerating all the orphan commits wouldn’t be that hard.

        In any case if a secret has been publicly disclosed, you should always assume it’s still out there. For sure, rotate your keys.

      • Mubelotix
        link
        fedilink
        English
        arrow-up
        10
        arrow-down
        5
        ·
        4 months ago

        Yes they exist. It’s called a clone

        • arcuru@lemmy.world
          link
          fedilink
          English
          arrow-up
          7
          ·
          4 months ago

          The article is specifically about how GitHub forks are not the same as a git clone. A clone isn’t accessible from the upstream without the upstream pulling the changes, but this vulnerability points out that a fork on GitHub is accessible from the upstream without a pull, even if the fork is private.

          It’s because GitHub under the hood doesn’t actually do a real clone so that they can save on disk usage.

          • Mubelotix
            link
            fedilink
            English
            arrow-up
            1
            arrow-down
            1
            ·
            4 months ago

            You actually can’t turn a fork private on github

        • best_username_ever@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          5
          arrow-down
          1
          ·
          4 months ago

          How can such a wrong answer get so many points? Clones and forge forks are unrelated. First, GitHub or GitLab cannot and could not link clones together without analyzing the remotes of each clone.

          FFS it’s a tech community…

          • Mubelotix
            link
            fedilink
            English
            arrow-up
            1
            arrow-down
            4
            ·
            4 months ago

            Because you are the one being wrong. Github and others only provide a nice interface around clones. That’s all there is, and it doesn’t matter much