I think along with an hypothetical version 1.0 (and maybe attracting new users and developers) we could clean/tidy a few other things as well, write some more developer documentation, where to look up how ActivityPub works, write down a few things from the video tour through the codebase as text, write some glossary about the terminology. Do a bit of cleanup work and delete old and unused CSS classes. Suppress the confusing exceptions in the maintenance task and fix the timeouts. Maybe gather stats from Celery and tie it into the admin interface.
Some suggestions that have worked for me for keeping a code base consistent with multiple developers working on it, and avoiding the technical debt of different styles:
- decide on formatting
- decide on linter and rules
- use pre-commit rules for the above
ruff is quick enough to use pre-commit. It also give helpful hints when linting, like
app/utils.py:924:16: E712 Avoid equality comparisons to
False; use
if not Community.banned:for false checks
Formatting the codebase is probably best done in a single merge commit. Fixing linter issues can be done whenever a file is worked on.
I’ve worked on Flask projects and switching to Poetry helped us with Flask plugin incompatibilities. At least it was detected by Poetry when adding them, not at runtime (that was what happened when Pip was used). Today I’d pick UV för dependency management.
Thanks, we’re going to start using ruff :)
I would absolutely love an easier way to deploy and more documentation on that process. I was able to get almost there but my system kept stopping working after docker compose up -d. It was more of a “see if I could do it” than anything else.
There’s quite a bit all over the place on the initial install. I think it should be two separate pages, one for containers and one for bare metal.
It looks like Rimu thinks the same - he’s created an Issue for himself here: https://codeberg.org/rimu/pyfedi/issues/411
Do a bit of cleanup work and delete old and unused CSS classes.
I don’t understand the CSS, so this would be very helpful.
Suppress the confusing exceptions in the maintenance task and fix the timeouts
Yeah, this would certainly make the info from sentry more useful - atm, it mostly seems to be errors from daily maintenance.
Another one along these lines: I noticed that the title of this post from the Friendica instance anonsys.net is rendered incorrectly. Here is the post from Lemmy.World where the community is located. The titles shown by the latter two match while PieFed’s is incorrect, and moreover what is shown is the third paragraph in the post, so it skips down past multiple ones before that.
I don’t see Friendica mentioned in the Roadmap, but it seems so close already!
Here’s the original content. You can see how messy it is to try to make a title out of it (Lemmy admittedly does a better job). My guess is that it skipped to the third paragraph because that was the first one without bold or italic formatting inside.
<p> 🚀 <b> A little guide on how to communicate with <a href=\"https://anonsys.net/search?tag=Lemmy\" class=\"mention hashtag\" rel=\"tag\">#<span>Lemmy</span></a> from <a href=\"https://anonsys.net/search?tag=Mastodon\" class=\"mention hashtag\" rel=\"tag\">#<span>Mastodon</span></a> <a href=\"https://anonsys.net/search?tag=Friendica\" class=\"mention hashtag\" rel=\"tag\">#<span>Friendica</span></a> <a href=\"https://anonsys.net/search?tag=Hubzilla\" class=\"mention hashtag\" rel=\"tag\">#<span>Hubzilla</span></a> <a href=\"https://anonsys.net/search?tag=Sharkey\" class=\"mention hashtag\" rel=\"tag\">#<span>Sharkey</span></a> etc</b> </p> <p> <i>(this is the English translation of this German post: <a href=\"https://anonsys.net/display/bf69967c-1664-9207-c6d7-3f2363787237\">anonsys.net/display/bf69967c-1…</a> If something is linguistically incorrect or incomprehensible, please let me know)</i> </p> <p> Lemmy is a kind of forum software in the <a href=\"https://anonsys.net/search?tag=Fediverse\" class=\"mention hashtag\" rel=\"tag\">#<span>Fediverse</span></a> : You can subscribe to forums (called ‘communities’ in Lemmy), share links and participate in discussions. <span class=\"h-card\"><a href=\"https://rollenspiel.social/users/Tealk\" class=\"u-url mention\">@<span>Tealk</span></a></span> and I have described it in more detail (in German) <a href=\"https://gnulinux.ch/fediverse-serie-willkommen-im-lemmyversum-communitys-im-fediverse\" target=\"_blank\" rel=\"noopener noreferrer\">here</a> </p> <p>... </p>
Lemmy.World repeats it - in both title area and as first text paragraph - and looks to strip the bold effect for the former but not the latter. Yeah I do like that approach better.
Btw I just read about your efforts getting a fork of Thunder working for PieFed and wanted to say that your efforts on behalf of everyone are so very appreciated:-).
your efforts on behalf of everyone are so very appreciated:-)
Thanks!